drop Python 3.3, update to use 3.6#462
Merged
minrk merged 4 commits intoipython:masterfrom Dec 8, 2017
Merged
Conversation
maartenbreddels
force-pushed
the
master
branch
from
4ec414a to
70830ed
Compare
blink1073
reviewed
Dec 7, 2017
setup.py
Outdated
| @@ -90,7 +90,6 @@ | |||
| # -- SUPPORT UNIFORM-WHEELS: Extra packages for Python 2.7, 3.3 | |||
Contributor
There was a problem hiding this comment.
this line mentions 3.3 as well
blink1073
approved these changes
Dec 7, 2017
Contributor
|
This is another option: https://github.com/ipython/ipykernel/blob/master/setup.py#L105. @minrk, I'd say dropping support for 3.3 is fine, but I'll defer to you here. |
Contributor
|
The end of life passed two months ago: https://www.python.org/dev/peps/pep-0398/#x-end-of-life |
Contributor
Author
|
I think this is a fluke, it had green lights before |
Member
|
yup, fine. Don't forget to set |
Contributor
Member
|
Thanks! |
Contributor
Author
|
👍 |
Carreau
added
5.0-re-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.